ACK. Look good, and doesn't break anything in my test scenarios (and we
have confirmation from the reporter in trac #784 that it fixes the OFB
case).
The "we abort if --no-iv is set without explicitly turning off NCP" is a
bit drastic, but acceptable, I think. Some people will need to change
their configs, so I've added a Changes.rst entry...
Your patch has been applied to the master branch.
commit 84f88ca4d57cd0dc40fd945e09ab1cea1b2cd0b7
Author: Steffan Karger
Date: Wed Dec 7 19:01:24 2016 +0100
Fix (and cleanup) crypto flags in combination with NCP
Signed-off-by: Steffan Karger <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg13428.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
