Hi, On Wed, Dec 14, 2016 at 10:08:25PM +0100, Steffan Karger wrote: > Looks good, but I think there's one more occurance you should > incorporate in the patch: > > if (openvpn_base64_encode(tok, AUTH_TOKEN_SIZE, > &multi->auth_token) < AUTH_TOKEN_SIZE)
Under which conditions can this ever fail? In other words: if this
fails, should we consider it a major programming error and ASSERT()?
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
