Le 12/16/16 à 18:03, Steffan Karger a écrit :
> On 16-12-16 17:32, Julien Muchembled wrote:
>> This fixes a regression in commit 8e95e20913:
>> on amd64, an implicit declaration of ERR_error_string leads to segfaults
>> if the returned pointer does not fit in an 'int'.
>>
>> Trac: #792
>>
>> [...]
> 
> ACK, fix is clearly correct.
> 
> Though there must be more then just 'on amd64' to make this break - this
> code has run an a *lot* of amd64 systems and this is the first breakage
> report.  (Of course that doesn't mean in any way that we shouldn't fix
> it, I'm just curious.)

As written in the subject, when HAVE_OPENSSL_ENGINE is unset, which may be 
rare. Or for those who don't have, the pointer fits on 32 bits (probably the 
case if linked statically).

I wrote more on #792 about what happened to us. We do build SSL with crypto, 
but HAVE_OPENSSL_ENGINE was unset because of typos in the configure command.

Julien

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to