On 16/12/16 18:14, David Sommerseth wrote:
> On 16/12/16 16:57, Christian Hesse wrote:
>> From: Christian Hesse <m...@eworm.de>
>>
>> Different unit instances create and destroy the same RuntimeDirectory.
>> This leads to running instances where the status file (and possibly
>> more runtime data) is no longer accessible.
>>
>> So create a RuntimeDirectory per instance.
>>
>> Signed-off-by: Christian Hesse <m...@eworm.de>
>> ---
>>  distro/systemd/openvpn-client@.service | 2 +-
>>  distro/systemd/openvpn-server@.service | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/distro/systemd/openvpn-client@.service 
>> b/distro/systemd/openvpn-client@.service
>> index 5618af3..fcb5302 100644
>> --- a/distro/systemd/openvpn-client@.service
>> +++ b/distro/systemd/openvpn-client@.service
>> @@ -9,7 +9,7 @@ 
>> Documentation=https://community.openvpn.net/openvpn/wiki/HOWTO
>>  [Service]
>>  Type=notify
>>  PrivateTmp=true
>> -RuntimeDirectory=openvpn-client
>> +RuntimeDirectory=openvpn-client@%i
>
> I am quite sure we tested this, without any luck.  We ended up with a
> directory named openvpn-client@%i ... well, we used openvpn-client-%i,
> but the principle should be the same.
>
> This *might* have been fixed in a newer systemd releases, but as we have
> RHEL7 as the oldest release we need to ensure this works properly there too.
>
> For the server side, we used status-%i.log to avoid clashing on the
> status log.
>
> debbie10t did plenty of testing with various configurations, so he can
> probably fill out more details in the various test cases he used.  We
> should probably document those tests in our wiki though.

This was spotted but I did not take sufficient ownership ..

I will happily test @Christian 's final patch.

regards

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to