On Sun, Dec 25, 2016 at 10:44:45AM +0100, Steffan Karger wrote: > > On 19-12-16 02:39, Antonio Quartulli wrote: > > Carrying around the INLINE_TAG is not really efficient, > > because it requires a strcmp() to be performed every > > time we want to understand if the data is stored inline > > or not. > > > > Convert all the *_inline attributes to bool to make the > > logic easier and checks more efficient. > > This makes sense, feature-ACK. > > > Signed-off-by: Antonio Quartulli <a...@unstable.cc> > > ---
[CUT] > > Seeing the recurring "don't accidentially print key data" issues, I > think adding a wrapper function to check for "[[INLINE]]" (and NULL?) > would make sense. I do agree on this. I thought I caught all the cases...but I left out some of them. I'll implement a small helper function and use it where needed. > Apart from that, this looks good te me! Thanks a lot for your feedback! I'll send v3 after including all your comments. Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
