Hi, One more real comment and two nitpicks:
On 15-01-17 15:43, Antonio Quartulli wrote: > @@ -3233,39 +3258,63 @@ options_postprocess_filechecks(struct options > *options) > > [...] > > + errs |= check_file_access_inline(options->cert_file_inline, CHKACC_FILE, > + options->cert_file, R_OK, "--cert"); This line has 1 indent too many. > + errs |= check_file_access_inline(options->extra_certs_file, CHKACC_FILE, > + options->extra_certs_file, R_OK, > + "--extra-certs"); I think the second one should be options->extra_certs_file_inline? > --- a/src/openvpn/ssl.c > +++ b/src/openvpn/ssl.c > @@ -542,7 +542,7 @@ tls_version_parse(const char *vstr, const char *extra) > */ > static void > tls_ctx_reload_crl(struct tls_root_ctx *ssl_ctx, const char *crl_file, > - const char *crl_file_inline) > + bool crl_file_inline) The doxygen string of the crl_file_inline parameter needs to be updated too (like you did in the header file for the non-static functions). Apart from these I am ready to give this an ACK. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
