2017-02-06 15:44 GMT+05:00 David Sommerseth <dav...@openvpn.net>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I have ACKed and applied this, just to get this one resolved. But I am
> very
> disappointed that you have yet again completely ignored the guidelines
> described in the URL[1] already provided to you - which describes how a
> patch
> and commit message should look like.
>
what I have learned is --annotate switch and, as you can see, now subject
contains "v2", so it is easy to distingush this patch and earlier edition.
>
> In fact - your SUBJECT line was 167 characters long, _including_ a URL. It
> did not even have a proper body message. *sigh*
>
it is the same as previous version of this patch, which I sent before your
guidelines, and you did not complain earlier.
it is not clear, how 167 chars long might be bad or good. for me it is just
167 chars.
if it is really bad, we might involve some automatic to submission process,
which will check how long is string.
@mattock ?
it is not trivial to be sure that it will fit your expectation.
as an example, there are automatic tests. and you are ok with that.
you do not being tedious "guys, I told you many times, write code without
bugs... why you are ignoring me..."
we should not assign machine job to a man, just involve some automation
which will tell "your commit message is too long" without involving your
time.
>
> You really need to stop wasting our [2] time and really read and truly
> learn
> what you read in a far better ways. If you do not change your behaviour
> here,
> the result will be that we will not put much efforts into your
> contributions
> in the future - unless we have a lot of time available, which, honestly,
> is not very happening often.
>
> Just ask yourself: If you care so little to play by our guidelines, why
> should we care about your patches?
>
> [1] <http://chris.beams.io/posts/git-commit/>
> [2] our ==> primarily developers and reviewers
>
>
> Regardless, your patch has been applied to the master branch
>
> commit 9e849c1e00a88abed65760ac7bee3df4aed2b754
> Author: Ilya Shipitsin
> Date: Mon Feb 6 11:55:15 2017 +0500
>
> github: Add PR template with contributor related information
>
> Acked-by: David Sommerseth <dav...@openvpn.net>
> Message-Id: <1486364115-9801-1-git-send-email-chipits...@gmail.com>
> URL: https://www.mail-archive.com/openvpn-devel@lists.
> sourceforge.net/msg14010.html
> Signed-off-by: David Sommerseth <dav...@openvpn.net>
>
>
> - --
> kind regards,
>
> David Sommerseth
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
>
> iQIcBAEBAgAGBQJYmFN/AAoJEIbPlEyWcf3yQoUP+wSNXtlDXyXgsGQpwoaPkuic
> u9wrjwtAxdizLXgtfNV0hY5ouoV9gEEA0L0UY+UmCi1Dk4cgGQq1uDyxDTytyW3q
> k6ilwzf8dCsa2KnWnJgF7ZTVmq8xn/XKj8FYJcNVI3sT9fWE+xUsJUHzINQmRVKc
> q9SrKC3BrCDJX6+pgQqMXwXE/i5iwBy+wAYILVQnQ936nOap0EsJFiI7pOqADNrf
> 6JlTzRJm1N+0sF54dX9eek27s4CuUDR+XMwO3DLp+qA3oCQfldFhwWz99aUR0DM4
> wloW0B3IRvcQAUWgIU3dDrMt78AzMZxd+BbPpCvKq6V6Msbk0AoUiQ+PduYEJ1bn
> 270iGhfL8mcMscGo7H/W2tHeZOpCzODlvflCEa83oFEiVYYltaIfxLpnoDiZ0gWy
> J4jCD4fqE5gcC3J7GkcpTtuSv+eYpjvNT8vsNSVaMHjrPESgfDWx1RYc2sqwbmCP
> uBcHWjBqJb8Fkq8r9cGc36+kAdfo3ljfPKSM+dtQxse/8U8xSMoMTjDpSAnJ8w2p
> s8gWU2rvB06gijBHxC4Bt9G3BXEPhRU4GKwP0Vnf8IGCVgXMyKf8nZZzWWs7/BAk
> ZzgXTfggHZLcuV9CxxpCLLDSe2NXk5Vapz+Y1AVh/bE+oRDooevxLzrLhnrdbFwQ
> FIXn7HqzCwJoxW7xP08c
> =IYjw
> -----END PGP SIGNATURE-----
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
