Hi, On Mon, Feb 20, 2017 at 02:13:20PM +0100, David Sommerseth wrote: > > and ran it against a local copy of lz4 v131, and that produced the > > expected result - no significant changes to compat-lz4.c/compat-lz4.h > > (the "#ifdef HAVE_CONFIG_H" block moves to the top of the file, but > > that is purely cosmetic - the block itself is fine) > > I /did/ consider to do some clever sed hacks here too ... but I wasn't > in mood for that complexity, and I actually feared how *BSD would > explode in my face :)
We'll always get you ;-)
> But as it turned out, the BSD explosion trigger
> was even lower than that ....... ;-)
GNU sed enables "more complex" matching by default, but I can never
remember which sed version does what, and when I need to turn on -E
("extended regex") to make sed do what I want :-)
> > So, any objections against the much simpler sed command there? "lz4.h"
> > with double quotes never shows up elsewhere in the file today - and
> > when importing, we need to run a compile test anyway, so if it should
> > ever garble the .c file, we fix the script...
>
> This is purely my "match a precise as possible" approach I default to.
> I have no issues making this simpler if that is what is required.
Understood, but in this particular case, I think "simple is good enough"
> New patch or fix at commit time?
Whatever you prefer. It's your code :)
(And since this is not "main openvpn code", the rules are not as strict
anyway - the actual lz4 commit change would need to be reviewed anyway)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
