Hi,

On 23-02-17 19:22, Ilya Shipitsin wrote:
> in rare cases openvpn is built from tarball, it happens during "installer 
> build"
> process. "make distcheck" helps to prevent problems during such builds.
> 
> Signed-off-by: Ilya Shipitsin <[email protected]>
> ---
>  .travis.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index a68374a..6ebfa39 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -79,6 +79,7 @@ script:
>    - if [ "${TRAVIS_OS_NAME}" = "osx"   ]; then export 
> DYLD_LIBRARY_PATH="${PREFIX}/lib:${DYLD_LIBRARY_PATH}"; fi
>    - autoreconf -vi
>    - ./configure --with-crypto-library="${SSLLIB}" ${EXTRA_CONFIG} || (cat 
> config.log && exit 1)
> +  - make distcheck > build.log 2>&1 || (cat build.log && exit 1)
>    - make -j$JOBS
>    - src/openvpn/openvpn --version || true
>    - if [ "${TRAVIS_OS_NAME}" = "linux" ]; then ldd src/openvpn/openvpn; fi
> 

Running 'make distcheck' from travis is a good idea.  But, I think it
should be done *after* 'make check'.  Futhermore, it would be nice to
only do this for one of the configurations, to keep our travis runs as
lightweight as possible (saves devs some waiting time, saves travis
energy/capacity).

-Steffan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to