On Sat, Mar 25, 2017 at 10:03:38PM +0500, Ilya Shipitsin wrote: > [src/openvpn/options.c:1163]: (warning) %x in format string (no. 1) requires > 'unsigned int *' but the argument type is 'signed int *'. > [src/openvpn/route.c:3187]: (warning) %d in format string (no. 5) requires > 'int *' but the argument type is 'unsigned int *'. > > v2: use "uint8_t" in options.c, thanks to Gert Doering
just my 2 cents here, but comments like the one above ("v2: ......") should go
after the "---" marker, because this way it does not get included in the git
message when committed in the repository.
version comments are useful during review to explain what was changed, but not
useful to the git history per se.
> Signed-off-by: Ilya Shipitsin <chipits...@gmail.com>
> ---
vX: change X, Y and Z.
Again, this is nothing important, but I thought it could be useful to share.
Cheers,
--
Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
