2017-03-28 11:56 GMT+05:00 Gert Doering <g...@greenie.muc.de>:
> Hi,
>
> On Tue, Mar 28, 2017 at 11:43:11AM +0500, ???????? ?????????????? wrote:
> > > (See how dangerous "fixing compiler warnings" is? :-) )
> >
> > this particular warning came from cppcheck, it's not a compiler warning
>
> Same thing. A tool that issues a warning which is not relevant the
> way the variables in question are used (because the values stored are
> always way below where signed/unsiged gets relevant) - but trying to fix
> it, I've misread the surrounding code and the "fixed" code would quite
> likely have crashed, or silently corrupted nearby variables.
>
>
cppcheck says "variable is signed, but format specification is unsigned"
so, I had a look around, it is "byte" variable, which cannot be signed, so
I decided to change it "int" --> "unsigned int"
later, Gert Doering suggested to switch to uit8_t
probably, we need to leave variable as is, just change format specification
"%x" --> "%d" ?
> gert
> --
> USENET is *not* the non-clickable part of WWW!
> //
> www.muc.de/~gert/
> Gert Doering - Munich, Germany
> g...@greenie.muc.de
> fax: +49-89-35655025 g...@net.informatik.tu-
> muenchen.de
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
