On 07/05/17 14:17, Antonio Quartulli wrote: > >> On 7 May 2017, at 20:15, Steffan Karger <stef...@karger.me> wrote: >> >> Hi, >> >> On 07-05-17 14:03, Antonio Quartulli wrote: >>> [...snip...] >>> I forgot: the good point of *not* having a default is that when you will >>> add a new enum value for that >>> particular enum type, the compiler will throw warnings for every switch >>> block you have, informing you >>> that now they need to be updated. Having a default will leave you with >>> manually check the various >>> code spots. >> >> This only holds when compiling with -Wall, which we do not do by default >> (because our current code would emit quite some warnings).
I actually do my local builds with -Wall, as well as the Fedora/Fedora EPEL builds do that too. It's not that terrifying as it once was. Well, currently most of the errors are in ntlm.c; the rest are just a few handful ones, where at least one of them already have a patch awaiting review on the ML (lz4 API update). >> If we would fix our code and compile with -Wall -Werror, I'd agree. But >> as long as we don't, I prefer a defensive code style where I can exclude >> undefined behaviour just by looking at the code. >> > > Agreed. This sounds like a call for a cleanup mission :] I presume you meant this on a generic level, not this patch explicitly, right? If so, I don't need to worry about a v3, as the v2 of this patch is already in this mail thread. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
