ACK, thanks.  (No tests run whatsoever, but we've had a discussion about
that on the security@ lists, and there was agreement that _countof is 
the thing to use - just nobody did it before, so thanks again :-) ).

Your patch has been applied to the master and release/2.4 branch.

Release/2.3 has "MAX_PATH" instead of sizeof or _countof, which is 
actually correct (but in contrast, it has no error checking for 
GetModuleFileNameW()...)

commit 986b930862c7fecb2a42645f1dc23a53ab2cf6bb (master)
commit 9092397ce02616b06c5c748de0b45775c7aa1e73 (release/2.4)
Author: Selva Nair
Date:   Thu May 11 21:32:34 2017 -0400

     Pass correct buffer size to GetModuleFileNameW()

     Signed-off-by: Selva Nair <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg14647.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to