On 17/05/17 21:14, Gert Doering wrote: > Hi, > > On Wed, May 17, 2017 at 10:53:58AM +0200, Adam ??tevko wrote: >> this patch adds support to build openvpn rpms with iproute2 support. It's a >> rather simple change, which defaults to off. Please review. > > Is there a particular reason not to *always* build with iproute2 support? > > David, what can a program expect to find on RPM based distributions?
It would surprise me if any of them these days don't have iproutes available. > (Is this .spec file what Fedora builds use?) Far from that. This .spec file is again horridly outdated, and I've done a ton of updates on the Fedora .spec files. To be very honest, I've been considering to strip the .spec file from our project. The approach of shipping a .spec made sense in the "old days" when the .spec file was merely just a script tackling a source tarball and patches; when distros where not that different from each other. But just looking at difference in the packaging guidelines between SUSE and Fedora today is just the first headache. Even though they mostly agree, they also have subtle different preferences on how to do things. Like, is the package called iproute or iproute2 ? Of course we could have a massive .spec file doing all the right things with lots of %if blocks .... but ... no, thank you very much! :) So then we would need to pick a flavour, or having a spec file per distro. And if we're doing that, we can rather just gather a list of pointers to various RPM distros' .spec files instead - with a "pick the one closest to your need". Those .spec files are hopefully better maintained than our .spec file will most likely be. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
