[Openvpn-devel] [PATCH] Refactor my_strupr such that it will not check and possibly alter bytes after the string's null terminator for strings of length 0

[Guido Vranken]

Signed-off-by: Guido Vranken <guidovran...@gmail.com>
---
 src/openvpn/ntlm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/openvpn/ntlm.c b/src/openvpn/ntlm.c
index 0c43681..9348337 100644
--- a/src/openvpn/ntlm.c
+++ b/src/openvpn/ntlm.c
@@ -130,17 +130,16 @@ gen_nonce(unsigned char *nonce)
     }
 }

-unsigned char *
+void
 my_strupr(unsigned char *str)
 {
     /* converts string to uppercase in place */
-    unsigned char *tmp = str;

-    do
+    while (*str)
     {
         *str = toupper(*str);
-    } while (*(++str));
-    return tmp;
+        str++;
+    }
 }

 static int
-- 
2.1.4

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel