Hi,
On Thu, Jun 08, 2017 at 11:56:38PM +0200, Guido Vranken wrote:
> + if ( !realm || !nonce )
> + {
> + goto error;
> + }
> +
Generally, ACK, as it solves the problem at hand.
I would prefer to see an error message here, though - after all, we've
already started talking to the proxy, and all of a sudden we silently(!)
decide "this proxy is no good" - this is not helpful in the face of a
true malfunction on the proxy side (and generally not what openvpn
tries to do).
I'd add something like:
msg(D_LINK_ERRORS, "HTTP proxy: digest auth failed, malformed response "
"from server: realm= or nonce= missing" );
so it's easier to see why it is giving up.
thanks :)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
