Hi, On Sat, Jun 10, 2017 at 07:46:46PM +0200, Jeremie Courreges-Anglas wrote: > --- a/src/openvpn/syshead.h > +++ b/src/openvpn/syshead.h > @@ -288,6 +288,10 @@ > #include <netinet/ip.h> > #endif > > +#ifdef HAVE_NETINET_TCP_H > +#include <netinet/tcp.h> > +#endif > +
*grumble* - our syshead.h has *five* such code blocks today...
$ grep -n netinet/tcp.h syshead.h
243:#include <netinet/tcp.h>
272:#include <netinet/tcp.h>
312:#include <netinet/tcp.h>
328:#include <netinet/tcp.h>
356:#include <netinet/tcp.h>
(Linux, Solaris, FreeBSD, NetBSD and Darwin/MacOS) - but not OpenBSD,
most recent additions
commit 37170767a221a4847416fc339083704ae1b4c001 (Darwin)
commit 3e86f688757529f8b33f9e6b49e31ba8d8564c5e (FreeBSD)
... so basically all platforms but Windows have an identical code
block afterwards... (and "but DragonFly", but I assume that if someone
would care about TCP_NODELAY there, we'd add another such chunk)...
Anyway: thanks for your patch, I'll add it later this weekend to
all relevant branches (2.3, 2.4, master) - and then send a refactoring
patch for master that joins all these into a common (unix) block...
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
