Thanks for sending v2 Steffan, On Wed, Jun 21, 2017 at 11:10:43PM +0200, Steffan Karger wrote: > From: Steffan Karger <steffan.kar...@fox-it.com> > > misc.c is a mess of incoherent functions, and is therefore included by > virtually all our source files. That makes testing harder than it should > be. As a first step of cleaning up misc.c, move adjust_power_of_2() to > integer.h, which is a more suitable place for a function like this. > > This allows us to remove the duplicate implementation from test_argv.c. > > Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com>
This change is quite simple and passes basic tests. Thanks also for adding explicit #include statements. Acked-by: Antonio Quartulli <anto...@openvpn.net> Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel