Hi, On 10/07/17 14:30, Gert Doering wrote: > Hi, > > On Mon, Jul 10, 2017 at 12:31:31PM +0800, Antonio Quartulli wrote: >> Instead of cluttering the code with these ifdefs directly in the main >> codebase, how about doing it in compat.h, like this (it's a copy/paste - >> code might be wrapper by the mail client): > > Better, but I wonder if we shouldn't fix this in configure.ac - "if the > system lz4 is older than what we bundle(*), use our compat-lz4.c instead" > > (*) ... or older than what we need, functionality-wise
If we do this, then we jump into the can of worms that David S. mentioned earlier, I think. Generally speaking, why not just depending on "libX >= a.b.c." and error out (at config time) if such lib is not available ? I think many other programs do exactly the same. If we still want, we could provide a configure switch that says "just use the bundled lz4", this way people may use it without installing a system-wide lib. Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
