Hi,

On Thu, Aug 24, 2017 at 09:33:05PM +0800, Antonio Quartulli wrote:
> The backquotes for command substitution in bash are
> considered old-style in favour of the more modern $() [1].
> Substitute them.
> 
> [1]https://www.gnu.org/software/bash/manual/html_node/Command-Substitution.html#Command-Substitution

We do, pointedly, *not* care about *bash* compatibility, but about
"it works on all the oddball shells you happen to find on any of the
supported platforms".

So, NAK, unless you have tested with ksh, and the system /bin/sh on at 
least Solaris and AIX.

Please do not change working shell script stuff just because *bash* says
"this is the more modern way!".

(gen-release-tarballs.sh only needs to work on FreeBSD and Linux, and
FreeBSD's /bin/sh is sufficiently modern so so it's likely to work
 - but the test scripts need to run robustly everywhere a user builds,
so never assume "because bash says so!" is a way anywhere but into worlds
of pain.  And yes, we've been there before :-) )

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to