Am 07.09.17 um 11:55 schrieb Antonio Quartulli: > From: Antonio Quartulli <anto...@openvpn.net> > > Commit 23d61c56 introduced the AF_UNSPEC socket family > to be used when we don't know the actual one until the local > socket binding is performed. > > In such case AF_UNSPEC is stored in the `ce.af` member of > the `c->options` object, indicating that the family has to be > determined at runtime. > > However, the determined value is never propagated back to the > `options` object, which remains AF_UNSPEC and that is > later used to initialize the TCP children contexts (UDP > children contexts are unaffected). > > This unexpected setting can trigger weird behaviours, like > the one reported in ticket #933. > In this case the value AF_UNSPEC in combination with the > changes implemented in 2bed089d are leading to a TCP > server quitting with M_FATAL upon client connection. > > Note that the misbehaviour described in #933 can only be > triggered when running a TCP server with mtu-disc set > in the config (no matter the value). > > Fix this inconsistency by always propagating the AF > family from the top to the child context when running > in TCP server mode. >
ACK. That is a really weird corner case that I must have missed :) Arne ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
