On Fri, Sep 15, 2017 at 11:40 AM, Gert Doering <g...@greenie.muc.de> wrote:

> Hi,
>
> On Fri, Sep 15, 2017 at 12:41:03AM -0400, selva.n...@gmail.com wrote:
> > From: Selva Nair <selva.n...@gmail.com>
> >
> > Eliminate the confusing message that says "explicit-exit-notify is
> ignored by
> > previous <connection> blocks" when the option is pushed.
> > Reported by: Eike Lohmann e.lohm...@ic3s.de
> > https://www.mail-archive.com/openvpn-users@lists.
> sourceforge.net/msg04052.html
>
> Not sure I understand that patch.  If I read it right (and I might not),
> won't this just make this option non-pushable, thus suppressing the error
> message by disabling the option?
>

No it doesn't change any functionality. By not including OPT_P_CONNECTION
in the mask sent to verify permission the previous connection blacks check
is disabled.  And this is done only when pull_mode is True.

So the only effect is just to suppress the message about previous
connection blocks when this option is parsed as a pushed option.

The key here is that check pull_mode to know that we are processing a
pushed option.

Selva

>
> gert
> --
> USENET is *not* the non-clickable part of WWW!
>                                                            //
> www.muc.de/~gert/
> Gert Doering - Munich, Germany
> g...@greenie.muc.de
> fax: +49-89-35655025                        g...@net.informatik.tu-
> muenchen.de
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to