Hi Simon, From a technical point of view, it looks like a fine patch. But it is hard for me (as a non-Windows dev) to understand *why* this is needed. It would be good to explain the rationale for a change so others can understand it as quickly as possible.
I won't dive deep into how to write good commit messages here, as this blog post covers it very well: <https://chris.beams.io/posts/git-commit/> For this particular patch, I hope Selva or Heiko get a chance to chime in with their technical review. -- kind regards, David Sommerseth OpenVPN, Inc On 11/10/17 01:11, si...@rozman.si wrote: > From: Simon Rozman <si...@rozman.si> > > --- > src/openvpnserv/interactive.c | 12 ++++++------ > src/openvpnserv/validate.c | 2 +- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c > index fe9c7d6..9d473e4 100644 > --- a/src/openvpnserv/interactive.c > +++ b/src/openvpnserv/interactive.c > @@ -402,8 +402,8 @@ ValidateOptions(HANDLE pipe, const WCHAR *workdir, const > WCHAR *options) > > if (!CheckOption(workdir, 2, argv_tmp, &settings)) > { > - snwprintf(buf, _countof(buf), msg1, argv[0], workdir, > - settings.ovpn_admin_group); > + _snwprintf(buf, _countof(buf), msg1, argv[0], workdir, > + settings.ovpn_admin_group); > buf[_countof(buf) - 1] = L'\0'; > ReturnError(pipe, ERROR_STARTUP_DATA, buf, 1, &exit_event); > } > @@ -421,15 +421,15 @@ ValidateOptions(HANDLE pipe, const WCHAR *workdir, > const WCHAR *options) > { > if (wcscmp(L"--config", argv[i]) == 0 && argc-i > 1) > { > - snwprintf(buf, _countof(buf), msg1, argv[i+1], workdir, > - settings.ovpn_admin_group); > + _snwprintf(buf, _countof(buf), msg1, argv[i+1], workdir, > + settings.ovpn_admin_group); > buf[_countof(buf) - 1] = L'\0'; > ReturnError(pipe, ERROR_STARTUP_DATA, buf, 1, &exit_event); > } > else > { > - snwprintf(buf, _countof(buf), msg2, argv[i], > - settings.ovpn_admin_group); > + _snwprintf(buf, _countof(buf), msg2, argv[i], > + settings.ovpn_admin_group); > buf[_countof(buf) - 1] = L'\0'; > ReturnError(pipe, ERROR_STARTUP_DATA, buf, 1, &exit_event); > } > diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c > index f6a97e9..7a2d0e3 100644 > --- a/src/openvpnserv/validate.c > +++ b/src/openvpnserv/validate.c > @@ -65,7 +65,7 @@ CheckConfigPath(const WCHAR *workdir, const WCHAR *fname, > const settings_t *s) > /* convert fname to full path */ > if (PathIsRelativeW(fname) ) > { > - snwprintf(tmp, _countof(tmp), L"%s\\%s", workdir, fname); > + _snwprintf(tmp, _countof(tmp), L"%s\\%s", workdir, fname); > tmp[_countof(tmp)-1] = L'\0'; > config_file = tmp; > } >
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
