Hi, > The best time to re-factor a function would be when a a new use case needs > to change its semantics. Apart from the ill-chosen -err as a return value, > currently it returns 0 if automatic metric is in use, making it impossible to > use > it as a generic function to find the current metric of an interface. > > In fact I've a pending patch where such a change would help. > > So, if you re-write this, consider some improvements: I think it belongs to > win32.c (declaration in win32.h). Second, return the current metric even if > Automatic metric is on (could indicate automatic metric needed in current > use case by a boolean parameter, probably). In case of error, logging it and > returning -1 should be good enough. > > Based on my tests, Windows does not permit setting a metric larger than > INT_MAX, so a return value of signed int is fine and convenient for indicating > error.
I shall give it a look after the Hackathon. Best regards, Simon ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
