Hi, On Sun, Dec 03, 2017 at 03:17:51PM +0100, Steffan Karger wrote: > On 02-12-17 14:45, Antonio Quartulli wrote: > > Now that ENABLE_CRYPTO has been removed, CIPHER_ENABLED is basically > > a useless shortcut which does not really help the readability of the > > code.
Call me silly, but CIPHER_ENABLED has nothing to do with ENABLE_CRYPTO, but more with "--cipher none", no? So at least the commit message is misleading... > > * Set adjustment factor for buffer alignment when no > > * cipher is used. > > */ > > - if (!CIPHER_ENABLED(c)) > > + if (!c->c1.ks.key_type.cipher) ... and I don't really find the second one more easily understandable than the first one... gert -- now what should I write here... Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
