Hi,
On 14-12-17 16:44, Gert Doering wrote:
> On Thu, Dec 14, 2017 at 11:21:37AM +0100, Steffan Karger wrote:
>> - if (!ret)
>> - {
>> - crypto_msg(M_FATAL, "Error creating %s BIO", desc);
>> - }
>
> I'm not sure how likely these are going to fail, but the crypto_msg()
> had the benefit of actually telling us what the underlying library
> returned as error code...
>
> If this won't ever happen except under very exceptional conditions, it
> won't matter much, though.
Fair point, but this is very unlikely to fail indeed. We use standard
openssl-provided BIO_METHOD's, and do not do threading. The one error I
could imagine is a malloc failure.
I still think it's fine to just go with the ASSERT().
-Steffan
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
