Hi, On Tue, Jan 16, 2018 at 10:24:08PM +0100, Arne Schwabe wrote: > if (rgi) > { > - buf_printf(&out, "%s %s %s dev %s", network, netmask, gateway, > rgi->iface); > + snprintf(out, sizeof(out), "%s %s %s dev %s", network, netmask, > gateway, rgi->iface);
Everything else uses openvpn_snprintf(), which presumably works around snprintf() platform undefined'ness wrt null-termination on too-long input. Most likely this is not *needed* on TARGET_ANDROID code, but for clarity it might be worth considering. gert -- now what should I write here... Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel