Hi, On Mon, Feb 19, 2018 at 3:18 PM, Selva Nair <[email protected]> wrote: > Hi, > > On Mon, Feb 19, 2018 at 3:16 AM, Steffan Karger > <[email protected]> wrote: >> Hi, >> >> On 18-02-18 20:04, Selva Nair wrote: >>> On Fri, Feb 16, 2018 at 8:45 AM, Steffan Karger >>> <[email protected]> wrote: >>>> Not all supported windows formatting libs are C99 compliant and some do not >>>> grasp %ll (similar to %zu). Use int64_t and PRIi64 to work around that. >>>> >>>> Signed-off-by: Steffan Karger <[email protected]> >>>> --- >>>> src/openvpn/error.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/src/openvpn/error.c b/src/openvpn/error.c >>>> index bf987d2..bc14e8c 100644 >>>> --- a/src/openvpn/error.c >>>> +++ b/src/openvpn/error.c >>>> @@ -342,8 +342,8 @@ x_msg_va(const unsigned int flags, const char *format, >>>> va_list arglist) >>>> struct timeval tv; >>>> gettimeofday(&tv, NULL); >>>> >>>> - fprintf(fp, "%lld.%06lu %x %s%s%s%s", >>>> - (long long)tv.tv_sec, >>>> + fprintf(fp, "%"PRIi64".%06lu %x %s%s%s%s", >>>> + (int64_t)tv.tv_sec, >>>> (unsigned long)tv.tv_usec, >>>> flags, >>>> prefix, >>>> -- >>> >>> This is good but there are a number of such instances (otime.c, >>> packet_id.c, forward.c etc. within code path relevant to Windows). >>> Many related to time_t like here, one or two other uses of %lld. And >>> may be more if some DEBUG flags are enabled. >>> >>> If those are left for future patches, that's ok. Just saying in case >>> its an oversight.. >> >> Good point - I did the lazy thing and just fixed what my compiler was >> complaining about. (My OpenVPN-NL buildbots build with >> "-Werror=implicit -Werror=format -Werror=format-security".) > > Makes sense.. But I'm surprised why it doesn't catch all errors. > >> >> For now, let's leave the rest - that doesn't break my build ;-)
Anyway, assuming that (i) my longer patch will take more time to get reviewed/tested and (ii) this is priority if a release is imminent, ACK from me. Acked-by: Selva Nair <[email protected]> (Only compile tested) Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
