Hi, On 23/02/18 20:02, Steffan Karger wrote: > Since reducing dependencies usually reduces maintenance burden, I prefer > this solution.
You're right here. Ok, let's keep md_full() then
>
>>> + {
>>> + msg(M_WARN, "WARNING: failed to personalise random");
>>> + }
>>> +
>>
>> Since we now have a reason for the failure, may it make sense to print a
>> proper description based on the return value? (even though I think
>> mbedtls_sha256_ret() can't really return something different from 0)
>
> md_full returns true/false, but you're right we can improve error
> reporting. Are you satisfied if I add an mbed_ok() wrapper *inside*
> md_full() to print the internal mbed error? I think that should be
> sufficient information.
Yeah, that would be nice. Thanks
I guess this patch fine as it is then. The mbed_ok() can be introduced
with another patch.
Acked-by: Antonio Quartulli <a...@unstable.cc>
Cheers,
--
Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
