Hi, On Fri, Apr 13, 2018 at 10:23:03AM -0700, Micah Morton wrote: > From 557d2e73bf21ddb9d07b43f716c7914d610e7392 Mon Sep 17 00:00:00 2001 > From: Micah Morton <mort...@chromium.org> > Date: Fri, 13 Apr 2018 09:55:22 -0700 > Subject: [PATCH] Specify platform and version on command line. > > Add --iv-plat and --iv-plat-rel command line args, and use the values > passed to these args to set IV_PLAT and IV_PLAT_REL info that is pushed > to the server. > > IV_PLAT (platform type) is normally inferred from the build target, but > it would be useful to be able to override this from the command line > (e.g. for client to set platform as ChromeOS instead of Linux). > > IV_PLAT_REL (platform release version) would allow for pushing the > platform (e.g. ChromeOS) release version to the server.
I'm actually less than enthusiastic about "yay, two more special-case options for OpenVPN" - and even less so to options that enable users to override a fairly well-defined meaning of IV_PLAT with an arbitrary string. Even if it's ChromeOS, compiled with #define TARGET_LINUX, IV_PLAT should reflect that. There is already "--setenv UV_anykey=value" to send arbitrary strings to the server, and in particular, IV_PLAT_VER can already be set by "--setenv IV_PLAT_VER=<version>". There's one catch to this, though - for some reason that escapes me right now we have decided that IV_PLAT_VER= and the UV_ user-defined strings are only sent if --push-peer-info is also configured on the client (while IV_GUI_VER, also settable with --setenv, is always sent). So we might want to revisit that decision. gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel