Hi, Il 18/04/2018 09:58, Gert Doering ha scritto: > Hi, > > On Tue, Apr 17, 2018 at 09:45:24PM -0400, Selva Nair wrote: >> (ii) The driver version shows up as 9.0.0.21 -- this is apparently taken >> from the inf file. Why is it not 9.21.3? The file version is 9.21.3 9/21 as >> expected.
I think the confusing versioning is just historic baggage which we have never bothered to fix. > I have no idea how the various values in version.m4 should work. There > are many numbers... > > What I have (after bumping all "21" to "22", and ".2/.3" to ".1") is: > > define([PRODUCT_NAME], [TAP-Windows]) > define([PRODUCT_PUBLISHER], [OpenVPN Technologies, Inc.]) > define([PRODUCT_VERSION], [9.22.1]) > define([PRODUCT_VERSION_RESOURCE], [9,0,0,22]) > define([PRODUCT_TAP_WIN_COMPONENT_ID], [tap0901]) > define([PRODUCT_TAP_WIN_MAJOR], [9]) > define([PRODUCT_TAP_WIN_MINOR], [22]) > define([PRODUCT_TAP_WIN_REVISION], [1]) > define([PRODUCT_TAP_WIN_BUILD], [601]) > > So, no idea what PRODUCT_VERSION_RESOURCE does and why it is not "9,22,1,0" > (or the like). > > It would certainly make things easier if that would output the same > number in all places. Agreed. I would love to bump 9,0,0,21 into 9,22,1,601. I _think_ Windows should be fine with that. We can discuss this in today's meeting. > > >> (iii) On Win7, the interface gets metric 20 --- implying a speed < 200 Mbps >> as per the Windows automatic metric assignment table. Isn't this supposed >> to get detected as a 1Gbps adapter now? The link speed patch is in master >> and this one is one point ahead of it (9.21.3), so expected to see it here. > > The test driver is based on master before the link speed patch, with an > independent version bump. Sorry for that confusion. > > gert > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
