Hi, On Tue, May 29, 2018 at 02:47:27PM +0300, Lev Stipakov wrote: > V2: style fixes > > - print protocol, source/dest addresses and ports > - mention "--allow-recursive-routing" > - add possible usecase to manpage > > Trac #843
I'm not sure I'm convinced. This is quite a lot of extra code for
an "add a few extra fields to a warning" enhancement - especially
given that those that are already confused by the warning today
will be more confused by "more numbers"...
> @@ -1094,7 +1099,7 @@ drop_if_recursive_routing(struct context *c, struct
> buffer *buf)
> const struct openvpn_iphdr *pip;
>
> /* make sure we got whole IP header */
> - if (BLEN(buf) < ((int) sizeof(struct openvpn_iphdr) + ip_hdr_offset))
> + if (BLEN(buf) < ((int)sizeof(struct openvpn_iphdr) + ip_hdr_offset))
In addition, these changes look funny. The existing code style was produced
by the scripted big code cleanup for 2.4, so there should never be a
reason to change the style in a patch for "master".
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
