From: Antonio Quartulli <anto...@openvpn.net>
Everytime a argv object is initialized with argv_new(), it has
to be released with argv_reset() once not needed anymore.
The same holds for gc_arena objects initialized with gc_new() that
have to be released with gc_free().
Ensure both kind of objects are always properly released to avoid
memory leaks.
Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
---
src/openvpn/tun.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 3eb0f78a..466d4d42 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -2615,6 +2615,8 @@ close_tun(struct tuntap *tt)
openvpn_execve_check(&argv, NULL, 0, "OpenBSD 'destroy tun interface'
failed (non-critical)");
free(tt);
+ argv_reset(&argv);
+ gc_free(&gc);
}
}
@@ -2700,6 +2702,8 @@ close_tun(struct tuntap *tt)
openvpn_execve_check(&argv, NULL, 0, "NetBSD 'destroy tun interface'
failed (non-critical)");
free(tt);
+ argv_reset(&argv);
+ gc_free(&gc);
}
}
@@ -2837,6 +2841,7 @@ close_tun(struct tuntap *tt)
openvpn_execve_check(&argv, NULL, 0, "FreeBSD 'destroy tun interface'
failed (non-critical)");
free(tt);
+ argv_reset(&argv);
}
}
@@ -3308,6 +3313,7 @@ open_tun(const char *dev, const char *dev_type, const
char *dev_node, struct tun
env_set_add( es, "ODMDIR=/etc/objrepos" );
openvpn_execve_check(&argv, es, S_FATAL, "AIX 'create tun interface'
failed");
env_set_destroy(es);
+ argv_reset(&argv);
}
else
{
@@ -3362,6 +3368,8 @@ close_tun(struct tuntap *tt)
free(tt);
env_set_destroy(es);
+ argv_reset(&argv);
+ gc_free(gc);
}
int
--
2.17.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
