Hi,
Copying the devel list as a reminder that "we" have been asking for this
change for a long time :)
On Fri, Jul 6, 2018 at 2:48 PM, Gert Doering <notificati...@github.com>
wrote:
> Hi,
>
> On Fri, Jul 06, 2018 at 08:25:02AM -0700, Selva Nair wrote:
> > Can we do something about this in openvpn core, so that the GUI can be
> report route errors?
Currently when we get CONNECTED,SUCCESS we turn the icon green. If we get
CONENCTED,ERROR we keep it amber and the state as "connecting.." even if
the initialization sequence completes.
> >
> > So route errors can still be treated as non-fatal but we want to get
> CONNECTED,ERROR in such cases.
>
> I still wonder why IPv4 route addition failures are considered
> non-fatal...
>
As failure in test_routes is considered an error (waiting for TAP to come
up..,
though not fatal) and leads to CONNECTED,ERROR, I guess that
CONNECTED,SUCCESS would imply the TUN/TAP is up and has got its
on-link route to the vpn subnet.
>
> But this aside ("it has always been that way", before I got involved),
> I can have look into how this signalling is done.
To make all route errors propagate to initilaization_sequence_completed()
one needs to return errors back up from a deep call chain:
check_add_routes_dowork -> check_add_routes_action -> do_route->
add_routes->etc.. Each of those calls returns void right now..
Selva
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
