Hi, On Thu, Jul 12, 2018 at 01:00:42AM +0800, Antonio Quartulli wrote: > stream_buf_init(), stream_buf_close() and stream_buf_added() > are only used within socket.c, therefore there is noneed to > have them declared in socket.h. > > Make them static and remove useless declarations. > This change required some re-ordering of the functions to > ensure they were defined before being used, however, no > this is just a copy/paste and no function change has been > introduced.
I'm not so happy about the large code move-around here, for small
benefit (code move-around breaks "git blame" to see which commit
introduced something, and why).
Why not just add prototypes at the top?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
