I agree. This was the consensus when we discussed this feature before, but there was some interest in possibly taking this work in an experimental branch and later building something more production-ready on top of the plumbing work. It is with that expectation I'm offering it upstream.
-----Original Message----- From: Selva Nair <selva.n...@gmail.com> Sent: Wednesday, July 25, 2018 10:28 AM To: Kevin Kane <kk...@microsoft.com> Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net> Subject: Re: [Openvpn-devel] [PATCH] [openvpn-gui] Update system tray to populate Windows VPN flyout Hi, On Wed, Jul 25, 2018 at 1:01 PM, Kevin Kane via Openvpn-devel <openvpn-devel@lists.sourceforge.net> wrote: > From ed96e2d91a0eb9ecdaab8d7104f397f7d77e5ced Mon Sep 17 00:00:00 2001 > > From: Kevin Kane <kk...@microsoft.com> > > Date: Fri, 13 Jul 2018 09:50:00 -0700 > > Subject: Update system tray to populate Windows VPN flyout > > > > Add a DLL to be wired in as a custom dialer, which introduces new > build dependencies > > Add copyright notices as required where Microsoft has contributed code > > > > Signed-off-by: Kevin Kane <kk...@microsoft.com> > As discussed in a previous thread, I'm not sure we should have this in its current form: (i) It adds and entry per config to network connections which will be a nuisance for users who have far too many configs (there are some users with 100's of config files) -- so we at least need an option to enable/disable this. (ii) This only supports connect, not disconnect and the entry does not show whether its connected or not -- so this is a feature of very dubious utility. (iii) Communicating with the GUI using COPYDATA message (we support connect, disconnect, status etc.) should be preferred over hard-coding IDM_CONNECTMENU. Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
