Acked-by: Gert Doering <[email protected]>

Because it's dead code.  Looking again, it actually seems correct
after all :-) (void_ptr_hash_function() is passed in a pointer *value*,
which is then stored locally, and the address of this local store is
handed to hash_func() - so it compares "memory addresses".  Misread the
code before.  It's James code so it must be correct.  But unused still!

Your patch has been applied to the master branch.

commit 01f7bb52ce510f0fc915c9aa6a14f79b2779a7f8
Author: Steffan Karger
Date:   Wed Sep 19 18:20:09 2018 +0200

     Remove unused void_ptr_hash_function and void_ptr_compare_function

     Signed-off-by: Steffan Karger <[email protected]>
     Acked-by: Gert Doering <[email protected]>
     Message-Id: <[email protected]>
     URL: 
https://www.mail-archive.com/[email protected]/msg17473.html
     Signed-off-by: Gert Doering <[email protected]>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to