On 19/09/18 18:37, Lev Stipakov wrote: > From: Lev Stipakov <l...@openvpn.net> > > This patch decouples setting/unsetting NCP options > from the state of TLS context. At startup (and then > per sighup) we load config (pre-NCP) values to c1, > which persists over sigusr1. When tearing tunnel down > we restore (possibly modified) c->options back to > c1 (original) values.
Just an annoying nitpick on the commit message. It's a good executive summary of what this change does. But it lacks the argument of "why" this change is needed, which is at least as important to the "executive summary" of the "how". The "Fixes" reference is good to have, but it's a too vague link when considering this commit might be scrutinized 10 years into the future - and Trac might not be available. And Trac references should normally be "Trac: #xxxx" Sorry for pestering about this, but good commit messages can really be time savers in the future. -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
