Hi, On 03-04-18 04:53, Selva Nair wrote: > But I can't believe I missed this in the last round. This else clause > will now get executed not only if options->cert_file is false, but > also if its true and the call to tls_ctx_use_external_private_key() > succeeds! That would be wrong and is not what we want.
Thanks for catching this before it went into master! For archiving purposes: this patch is no longer needed because it has been superseded by the refactoring in "Do not load certificate from tls_ctx_use_external_private_key()" (Message-Id: <1536916459-25900-1-git-send-email-steffan.kar...@fox-it.com>). I'll register it like so in patchwork too. -Steffan _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
