Hi,
On Mon, Oct 08, 2018 at 07:35:54PM +0300, Lev Stipakov wrote:
> out:
> - free(cmdline);
> + if (cmdline)
> + {
> + free(cmdline);
> + }
Do we have something in our styleguides related to these constructs?
Since free(NULL) is well-defined and valid(!), the if() check is not
needed at all and just adding extra lines on screen.
I'm sure we had this discussion before, but couldn't find something
where we wrote down how and why we do things. We do have parts of
the code that *does* "if(ptr) { free(ptr); }" checks, and others that
don't... for example, AsyncPipeOp() on failure to malloc() "handles".
(Of course cmdline needs to be initialized with NULL - not argueing
*that* part)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
