Hi, On Wed, Dec 12, 2018 at 11:50:20PM +0100, David Sommerseth wrote: > I do see my uncrustify run have some weird disagreements in > src/openvpn/push.c, where it wants to indent all the switch case parts one > more level. Not sure why this didn't hit Gerts run though, this change does > seem appropriate to our CodeStyle wiki page.
This is Arne's forget-auth-token patch which added a level of brackets
but did not re-indent the switch/case part (e61b401ac5). I commented
on this in the "merge and pushed" mail, but decided to merge it nonetheless
as this is another one that had been going in circles for too many moons...
[..]
> But I think we just need to accept that we can only push uncrustify to some
> degree towards our desired coding style and then to accept the minor gaps to
> our view of full perfection.
I am fine with this. Yes, some of the changes look funky, and I wouldn't
personally do other stuff, but I can live with the result - and it's way
better than having to argue style questions all the time, instead of
focusing on code and "possible logic flaws in the code".
> Telling contributors to "run your changes
> through uncrustify before sending patches" will definitely help.
Indeed.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
