On 18/06/2019 18:34, Antonio Quartulli wrote:
> From: Antonio Quartulli <anto...@openvpn.net>
> 
> 1) Building the networking unit-test when SITNL is not enabled does not
> make much sense right now.
> Make compilation dependent on having SITNL configured.
> 
> 2) Remove some no-op mock_msg function calls.
> 
> 3) Remove obsolete comment and declarations
> 
> Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
> ---
> 
> Changes from v1:
> - get rid of LD_LIBRARY_PATH: consensus is to have cmocka installed
>   system-wide
> 
>  tests/t_net.sh                             |  6 +-----
>  tests/unit_tests/openvpn/Makefile.am       |  2 ++
>  tests/unit_tests/openvpn/test_networking.c | 16 ----------------
>  3 files changed, 3 insertions(+), 21 deletions(-)


Only glared at the code changes, and it makes sense after some clarifications
on IRC.

Acked-by: David Sommerseth <dav...@openvpn.net>


-- 
kind regards,

David Sommerseth
OpenVPN Inc


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to