Acked-by: Arne Schwabe <>
Acked-by: Gert Doering <>

Passes the manual "--show-gateway <thing>" test now, and survived 
staring-at-the-code.  Though that one turned up things elsewhere that
I do not like very much (but which have already been merged) - see
next mail.

I said before I'm not a big fan of having an "int flags" declaration
at the beginning of a function for a single-use helper variable further 
down - C99 permits "int flags = ..." right where the thing is needed, 
and I find that much more readable (I wouldn't introduce "flags" at 
all, but if you do, having to look in two places "what is this?  is 
this used anywhere else?" is more review effort).  But you ignored that
comment, and I'm not disliking this enough for a NAK.

Your patch has been applied to the master branch.

commit c454b21e7ce458ce6f5bcaf6c313ab3ba3dd5baf
Author: Antonio Quartulli
Date:   Mon Jul 15 16:46:09 2019 +0200

     route.c: use sitnl to implement get_default_gateway_ipv6()

     Signed-off-by: Antonio Quartulli <>
     Acked-by: Arne Schwabe <>
     Acked-by: Gert Doering <>
     Message-Id: <>
     Signed-off-by: Gert Doering <>

kind regards,

Gert Doering

Openvpn-devel mailing list

Reply via email to