Your patch has been applied to the master branch.

I have not tried to understand the actual change, but the general
explanation makes sense and with two ACKs already... I did run t_client
tests, though :-)  (and there is a fragment test).

I did try to apply it to 2.4, because it's a bugfix (so "can I have it
for release/2.4, please!") and while it *applied* fine, it did not 
compile :-( - the function signature for crypto_adjust_frame_parameters() 
is different in 2.4 - "use_iv" still exists.  Can you have a look, 
please, and send a 2.4 version?

commit d22ba6b2c551fa83d23b5cf668e08a08fde446bc (master)
Author: Lev Stipakov
Date:   Mon Jan 21 22:04:54 2019 +0200

     Fix broken fragment/mssfix with NCP

     Signed-off-by: Lev Stipakov <lstipa...@gmail.com>
     Acked-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Steffan Karger <steffan.kar...@fox-it.com>
     Message-Id: <1548101094-4449-1-git-send-email-lstipa...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18135.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to