Hi, On 13/08/2019 23:26, David Sommerseth wrote: > wouldn't it be better to > do 'if (rgi6->iface)' instead? Since the buffer should be NULL terminated > and has to be NULL terminted for strlen() to function anyhow. But the > compiled code would be a bit more efficient (even though, this isn't > necessarily a performance critical code section).
In my opinion strlen() is more readable for the casual developer checking this code. Behind iface we may hide other ambiguous assumptions (even though this is not the case here, but we won't remember in some months from now). Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpnfirstname.lastname@example.org https://lists.sourceforge.net/lists/listinfo/openvpn-devel