Acked-by: Gert Doering <g...@greenie.muc.de> Interesting remark from Casper Dik - strncpy() actually is defined to *always* write all IFNAMSIZ bytes (so says the linux man page), unlike strcpy() which stops after the '\0' byte. But in this particular case, "not overrunning" is more important than "save a few cycles on a short interface name". But it was certainly news to me.
Now all strings involved are guaranteed to always have the same length. Thanks. Your patch has been applied to the master branch. commit 8a05f860af386cd135ee1aacb0d5eccc49c466bb Author: Antonio Quartulli Date: Mon Aug 5 11:25:24 2019 +0200 sitnl: harden strncpy() by forcing arguments to have the same length Signed-off-by: Antonio Quartulli <anto...@openvpn.net> Acked-by: Gert Doering <g...@greenie.muc.de> Message-Id: <20190805092529.9467-...@unstable.cc> URL: https://firstname.lastname@example.org/msg18722.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpnemail@example.com https://lists.sourceforge.net/lists/listinfo/openvpn-devel