Hi,
On 19/09/2019 11:17, Steffan Karger wrote:
>> diff --git a/tests/t_net.sh b/tests/t_net.sh
>> index 18799d12..97e947ab 100755
>> --- a/tests/t_net.sh
>> +++ b/tests/t_net.sh
>> @@ -34,6 +34,13 @@ reload_dummy()
>> {
>> $RUN_SUDO $openvpn --dev $IFACE --dev-type tun --rmtun >/dev/null
>> $RUN_SUDO $openvpn --dev $IFACE --dev-type tun --mktun >/dev/null
>> +
>> + # it seems that tun devices will settle on NO-CARRIER while not
>> connected to
>> + # any process, but this won't happen immediately. To avoid having the
>> + # NO-CARRIER bit appear in the middle of the tests - which would
>> compromise
>> + # the results - let's wait 1 sec here for it to settle.
>> + sleep 1
>> +
>> if [ $? -ne 0 ]; then
>> echo "can't create interface $IFACE"
>> exit 1
>>
>
> This return value check now checks that sleep succeeded instead of the
> openvpn --mktun command. I don't think that is what you intended.
> You're absolutely right. The sleep should be moved right after the if-check. Will send a new patch to fix that. Regards, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
