Taking Simon's "LGTM" as an ACK (plus some own light staring at the code changes which seem to make sense). Test built ("it compiles, ship it!") on ubuntu 1604/mingw.
Your patch has been applied to the master branch. Acked-by: Simon Rozman <si...@rozman.si> commit e9ce348c93b99e76959b89739fbd74c43ee50152 Author: Lev Stipakov Date: Mon Sep 23 12:08:02 2019 +0300 tapctl: add optional 'hardware id' parameter Signed-off-by: Lev Stipakov <l...@openvpn.net> Acked-by: Simon Rozman <si...@rozman.si> Message-Id: <1569229682-9731-1-git-send-email-lstipa...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18854.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel