Hi, On 09/10/2019 11:52, Gert Doering wrote: > The "route add" code always used "metric 0" on OpenSolaris, because > (on tun interfaces) it was required to make the route work on > "non-ethernet" interfaces (connected, no NDP). > > This breaks routes via tap interfaces on recent Solaris versions > (tested on OpenIndiana 2019) - there, routes only work if metric > is != 0 (or just not set). Otherwise it tries to map the gateway > address to a local address and fails. >
I have no means to test the code so I only stared at it and ensured it
was affecting the SOLARIS platform code only. It does what the commit
says and it makes sense in the solaris-nonsense-world.
Gert has performed some live tests on his new OpenIndiana 2019 host
(where the problem was observed) and ensured it worked fine.
Acked-by: Antonio Quartulli <anto...@openvpn.net>
> Signed-off-by: Gert Doering <g...@greenie.muc.de>
> ---
> src/openvpn/route.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/openvpn/route.c b/src/openvpn/route.c
> index 3183fb47..97e90e56 100644
> --- a/src/openvpn/route.c
> +++ b/src/openvpn/route.c
> @@ -2043,8 +2043,8 @@ add_route_ipv6(struct route_ipv6 *r6, const struct
> tuntap *tt,
> r6->netbits,
> gateway );
>
> - /* on tun/tap, not "elsewhere"? -> metric 0 */
> - if (!r6->iface)
> + /* on tun (not tap), not "elsewhere"? -> metric 0 */
> + if (tt->type == DEV_TYPE_TUN && !r6->iface)
> {
> argv_printf_cat(&argv, "0");
> }
>
--
Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
