Your patch has been applied to the master branch.
I have "forward-logged" Steffan's ACK on the v6 patch as the v8 is
close enough, except for the "struct win_tun" change (which look
reasonable), plus Simon's ACK.
What I do not like is code that uses malloc() and then calls ZeroMemory()
right after. calloc() exists. Standard-based, less lines of code.
No reason to NAK this, but maybe this can be fixed in a followup patch
(and put on our styleguide somewhere?)...
Compile-tested on Ubuntu 16.04 / mingw (which worked fine). No own
code review or any sort of testing done.
commit d5fc4bd41616ee01816df873cb6b6567872a29e2
Author: Lev Stipakov
Date: Tue Dec 17 14:44:10 2019 +0200
wintun: ring buffers based I/O
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Steffan Karger <[email protected]>
Acked-by: Simon Rozman <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg19243.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
